fix and rewrite bytebuf api #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-yh-china
requested changes
May 23, 2024
|
现在格式应该没问题了（吧） |
|
我觉得除了新开一个handler以外都还好。 改成类似wrapper？ |
|
感谢反射和泛型 添加了chat component的支持，具体见 https://github.com/Lumine1909/BytebufAPIExample |
新开是因为bukkit的event实现可能有性能问题（详见群） |
我现在够不到QQ群啊（大叫），discord and github only. |
Bluemangoo
reviewed
May 24, 2024
bkapi的 callEvent用到了反射，而packet是一个极其频繁的事件 可能导致之后 |
Bluemangoo
approved these changes
May 24, 2024
Lumine1909
added a commit
to Lumine1909/LeavesFork
that referenced
this pull request
Sep 15, 2024
--------- Co-authored-by: violetc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
重写了api，适配 1.20.6
支持更多数据包，添加了数据包监听功能
所有新内容已完成本地测试
食用方法: https://github.com/Lumine1909/BytebufAPIExample